Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error property to server logs #585

Merged
merged 2 commits into from Mar 21, 2018
Merged

Add error property to server logs #585

merged 2 commits into from Mar 21, 2018

Conversation

@rankida
Copy link
Contributor

rankida commented Mar 16, 2018

As of Hapi17 calls to server.log that pass an error instances as the data will append the error to event.error and not event.data. As such this needs to be captured by good's ServerLog class.

@Marsup Marsup added the bug label Mar 21, 2018
@Marsup Marsup added this to the 8.1.1 milestone Mar 21, 2018
@Marsup Marsup self-assigned this Mar 21, 2018
@Marsup Marsup merged commit 30441d3 into hapijs:master Mar 21, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@arb

This comment has been minimized.

Copy link
Contributor

arb commented Mar 21, 2018

Thanks @Marsup and @rankida

@rankida rankida deleted the rankida:log-errors branch Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.