Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to new versions of modules and ES6. #20

Merged
merged 1 commit into from Dec 14, 2015
Merged

Migrate to new versions of modules and ES6. #20

merged 1 commit into from Dec 14, 2015

Conversation

@osukaa
Copy link
Contributor

osukaa commented Dec 10, 2015

I'm upgrading the versions for all the Hapi modules plus moving to ES6 with the support for Node 4+. This also closes #15

@osukaa osukaa self-assigned this Dec 10, 2015
@osukaa osukaa added this to the 5.0.0 milestone Dec 10, 2015
@mark-bradshaw

This comment has been minimized.

Copy link

mark-bradshaw commented Dec 10, 2015

This may sound strange, but switch lines 125 - 127 to:

if (settings.xforward &&
                request.info.remotePort &&
                request.info.remoteAddress ) {
.travis.yml Outdated
- 0.10
- 0.12
- iojs
- 4.0

This comment has been minimized.

Copy link
@Marsup

Marsup Dec 10, 2015

Member

Quotes around all version numbers.

"hoek": "2.x.x",
"joi": "6.x.x",
"wreck": "6.x.x"
"boom": "^2.10.1",

This comment has been minimized.

Copy link
@Marsup

Marsup Dec 10, 2015

Member

v.x.x format

README.md Outdated
The [response flow control rules](#flow-control) **do not** apply.

```js
var handler = function (request, reply) {

This comment has been minimized.

Copy link
@Marsup

Marsup Dec 10, 2015

Member

ES6 even in examples -> const

@osukaa osukaa mentioned this pull request Dec 13, 2015
Update travis yml

Fix typo

Add return to statement

Add quotes around node versions

Change var to const on docs

Change version format for dependencies

Change lines for testing coverage purposes

Update readme to reflect that the minimal option is no longer existent.
@osukaa osukaa force-pushed the migrateNode4 branch from 68c4caf to 81ad1c1 Dec 13, 2015
osukaa added a commit that referenced this pull request Dec 14, 2015
Migrate to new versions of hapi modules and ES6.
@osukaa osukaa merged commit 1a9ba9e into master Dec 14, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@osukaa osukaa deleted the migrateNode4 branch Dec 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.