Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the `uri` vs. `address` variable usage for multiple replacements #45

Merged
merged 2 commits into from Oct 10, 2016

Conversation

@EyePulp
Copy link
Contributor

EyePulp commented Oct 10, 2016

Also add to to the test to verify that multiple subsequent replacements are cumulative.

@osukaa osukaa added this to the 5.3.0 milestone Oct 10, 2016
@osukaa

This comment has been minimized.

Copy link
Contributor

osukaa commented Oct 10, 2016

@EyePulp I'll merge and publish this in the afternoon (around 5PM CST)

@EyePulp

This comment has been minimized.

Copy link
Contributor Author

EyePulp commented Oct 10, 2016

Thanks, and sorry for all the trouble.

@osukaa

This comment has been minimized.

Copy link
Contributor

osukaa commented Oct 10, 2016

No worries

El El lun, 10 de oct. de 2016 a las 08:12, EyePulp notifications@github.com
escribió:

Thanks and sorry for all the trouble.


You are receiving this because you commented.

Reply to this email directly, view it on GitHub
#45 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAi5f__1B8q5rmG7TYh9uMrtHYPN3NAzks5qykfPgaJpZM4KSjZ2
.

Sent from Inbox

@osukaa osukaa merged commit 68b195e into hapijs:master Oct 10, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@osukaa

This comment has been minimized.

Copy link
Contributor

osukaa commented Oct 10, 2016

It's been published, but because of the new npm unpublish rules I had to publish 5.4.0 instead of 5.3.0

@EyePulp

This comment has been minimized.

Copy link
Contributor Author

EyePulp commented Oct 11, 2016

Sweet! Thanks so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.