New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add password rotation support #194

Open
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@wzrdtales

wzrdtales commented Apr 8, 2018

Fixes #193

Signed-off-by: Tobias Gurtzick magic@wizardtales.com

wzrdtales added some commits Apr 8, 2018

add password rotation support
Signed-off-by: Tobias Gurtzick <magic@wizardtales.com>
allow any object alternatively
Signed-off-by: Tobias Gurtzick <magic@wizardtales.com>

@mrlannigan mrlannigan self-requested a review May 27, 2018

@mrlannigan mrlannigan added this to the 9.0.0 milestone May 27, 2018

@mrlannigan

This comment has been minimized.

Contributor

mrlannigan commented May 27, 2018

Hello @wzrdtales,

Thank you for your contribution!

A couple of things:

  • Can you take this opportunity to improve the documentation for the password?
  • Can you address the broken build?

@mrlannigan mrlannigan modified the milestones: 9.0.0, 9.0.1 May 27, 2018

@wzrdtales

This comment has been minimized.

wzrdtales commented May 28, 2018

Will do wasn't sure if this is even maintained so did not yet bothered to do this and hard forked instead. Patches will follow :)

fix linting errors
Signed-off-by: Tobias Gurtzick <magic@wizardtales.com>
@wzrdtales

This comment has been minimized.

wzrdtales commented Jul 15, 2018

Added docs and fixed test, sry for the delay :)

add documentation
Signed-off-by: Tobias Gurtzick <magic@wizardtales.com>

@wzrdtales wzrdtales force-pushed the wzrdtales:addRotationSupport branch from 2e8c47b to dc81f23 Jul 15, 2018

@mrlannigan

This comment has been minimized.

Contributor

mrlannigan commented Jul 16, 2018

@wzrdtales Seems like you may have included style changes that don't match the hapijs style guide. It's hard to tell what has actually changed in the documentation because of all the whitespacing and quote changes. Can you please correct this?

@wzrdtales

This comment has been minimized.

wzrdtales commented Jul 16, 2018

Nah I didn't my editor did, unfortunately you did not configured your project for any CS at all and neither the hapi styles have a proper set of autocorrections, so this is actually why that happened. Had that problem already with other projects of hapi... .

Will correct it in some far future.

@hueniverse hueniverse removed this from the 9.1.0 milestone Nov 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment