Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server throttling controls do not log execution #1573

Closed
kpdecker opened this issue Apr 15, 2014 · 2 comments
Closed

Server throttling controls do not log execution #1573

kpdecker opened this issue Apr 15, 2014 · 2 comments
Assignees
Labels
Milestone

Comments

@kpdecker
Copy link
Contributor

@kpdecker kpdecker commented Apr 15, 2014

The "Server under heavy load" throttling implementation does not log anything to the log stream other than the status code, which makes it difficult to determine when this is firing or not.

Ideally this should log some sort of unique token showing that it triggered and would also log information about the values that were there at the time of exec, i.e. the current loop delay, etc.

https://github.com/spumko/hapi/blob/master/lib/server.js#L248

@hueniverse
Copy link
Contributor

@hueniverse hueniverse commented May 24, 2014

Unique token? Not following. As for the load values, they are logs as the error data. It is up to the logging engine to expose that data.

Loading

@hueniverse hueniverse added this to the 5.0.1 milestone May 24, 2014
@hueniverse hueniverse self-assigned this May 24, 2014
@Marsup Marsup added feature and removed request labels Sep 20, 2019
@lock
Copy link

@lock lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

Loading

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants