Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hapi 6.0 no longer invalidates auth strategy on registration of route #1708

Closed
biant opened this issue Jun 11, 2014 · 2 comments
Closed

Hapi 6.0 no longer invalidates auth strategy on registration of route #1708

biant opened this issue Jun 11, 2014 · 2 comments
Assignees
Labels
Milestone

Comments

@biant
Copy link

@biant biant commented Jun 11, 2014

In previous versions server.route() would validate the name of the configured auth strategy and throw an exception if the name was not already registered with server.auth.strategy()

To reproduce check the this unit test in hapi-auth-basic:
https://github.com/spumko/hapi-auth-basic/blob/master/test/index.js#L349

@biant biant added the bug label Jun 11, 2014
@hueniverse hueniverse added this to the 6.0.0 milestone Jun 12, 2014
@hueniverse hueniverse self-assigned this Jun 12, 2014
@hueniverse
Copy link
Contributor

@hueniverse hueniverse commented Jun 12, 2014

@biant Good catch. This test was moved to hapi-auth-basic when we split it and it should have stayed in hapi. I moved it here so you can drop it from basic.

Loading

@biant
Copy link
Author

@biant biant commented Jun 12, 2014

@hueniverse removed the unit test from hapi-auth-basic

Loading

@lock lock bot locked as resolved and limited conversation to collaborators Jan 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants