Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File handler to handle 206 Partial Content? #1754

Closed
PaulMougel opened this issue Jul 3, 2014 · 3 comments
Closed

File handler to handle 206 Partial Content? #1754

PaulMougel opened this issue Jul 3, 2014 · 3 comments
Assignees
Labels
Milestone

Comments

@PaulMougel
Copy link

@PaulMougel PaulMougel commented Jul 3, 2014

It seems like handler: {file: 'somefile.txt'} always streams the full file to the client. I need to handle 206 partial requests (for context, my specific issue lies with <video> element seeking that is not handled by Chrome if the server doesn't answer with Content-Range headers, see this SO answer for instance).

If I were to implement this, would it be merged? Can anyone give me some pointers on where to implement it?

@PaulMougel PaulMougel changed the title reply.file() to handle 206 Partial Content? File handler to handle 206 Partial Content? Jul 5, 2014
hueniverse pushed a commit that referenced this issue Jul 13, 2014
@hueniverse hueniverse added this to the 6.0.3 milestone Jul 13, 2014
@hueniverse hueniverse self-assigned this Jul 13, 2014
hueniverse pushed a commit that referenced this issue Jul 13, 2014
@PaulMougel
Copy link
Author

@PaulMougel PaulMougel commented Jul 16, 2014

Awesome, thanks a lot Eran! 👍
This looks way better than the half-assed implementation I was working on.

@hueniverse
Copy link
Contributor

@hueniverse hueniverse commented Jul 17, 2014

I still want to add support for multi ranges requests but that's rarely needed.

@Marsup Marsup added feature and removed request labels Sep 20, 2019
@lock
Copy link

@lock lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants