Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Last-Modified comparison needs to account for 1 second precision #1788

Closed
hueniverse opened this issue Jul 16, 2014 · 3 comments
Closed

Last-Modified comparison needs to account for 1 second precision #1788

hueniverse opened this issue Jul 16, 2014 · 3 comments
Assignees
@hueniverse
Labels
non issue Issue is not a problem or requires changes
Milestone
6.1.0

Comments

@hueniverse
Copy link
Contributor

No description provided.

@hueniverse hueniverse added this to the 6.1.0 milestone Jul 16, 2014
@hueniverse hueniverse added the bug label Jul 16, 2014
@hueniverse hueniverse self-assigned this Jul 16, 2014
@hueniverse hueniverse changed the title Last-Modified test need to account for 1 second precision Last-Modified comparison needs to account for 1 second precision Jul 16, 2014
@hueniverse
Copy link
Contributor Author

Hmm. Not sure about this anymore...

@hueniverse hueniverse added non-issue and removed bug labels Jul 16, 2014
@hueniverse hueniverse reopened this Jul 16, 2014
hueniverse pushed a commit that referenced this issue Jul 16, 2014
Undo #1788
4d10852
@bleupen
Copy link

bleupen commented Oct 30, 2014

If my request has an if-modified-since header of "Thu Oct 30 2014 13:43:51 GMT-0400" and i generate a response with a last-modified header of "2014-10-30T13:43:51.899Z" (ie after but within the same second), hapi will send a 304. Is this the correct behavior?

@hueniverse
Copy link
Contributor Author

Header comparison is at 1 second granularity.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hueniverse hueniverse

Labels
non issue Issue is not a problem or requires changes
Projects
None yet
Milestone
6.1.0
Development

No branches or pull requests
2 participants
@hueniverse @bleupen