Session scope does not match one to many auth.scope on route.

[poeticninja]

The session scope will not match the auth.scope if auth scope is an array and the session scope is more than one character.

Here are three test examples.

This works but we are only match one character.

// Success
    it('matches scope array item', function (done) {

        var server = new Hapi.Server();
        server.auth.scheme('custom', internals.implementation);
        server.auth.strategy('default', 'custom', true, { users: { steve: { scope: 'a' } } });
        server.route({
            method: 'GET',
            path: '/',
            config: {
                handler: function (request, reply) { reply(request.auth.credentials.user); },
                auth: {
                    scope: ['a', 'c']
                }
            }
        });

        server.inject({ url: '/', headers: { authorization: 'Custom steve' } }, function (res) {

            expect(res.statusCode).to.equal(200);
            done();
        });
    });

This works with user scope an array match and the match is more than one character.

// Success
    it('matches scope array item', function (done) {

        var server = new Hapi.Server();
        server.auth.scheme('custom', internals.implementation);
        server.auth.strategy('default', 'custom', true, { users: { steve: { scope: ['ab', 'cat'] } } });
        server.route({
            method: 'GET',
            path: '/',
            config: {
                handler: function (request, reply) { reply(request.auth.credentials.user); },
                auth: {
                    scope: ['ab', 'cat']
                }
            }
        });

        server.inject({ url: '/', headers: { authorization: 'Custom steve' } }, function (res) {

            expect(res.statusCode).to.equal(200);
            done();
        });
    });

This fails, the user scope is not an array and the match needs to be more than one character.

// Failed
    it('matches scope array item', function (done) {

        var server = new Hapi.Server();
        server.auth.scheme('custom', internals.implementation);
        server.auth.strategy('default', 'custom', true, { users: { steve: { scope: 'ab' } } });
        server.route({
            method: 'GET',
            path: '/',
            config: {
                handler: function (request, reply) { reply(request.auth.credentials.user); },
                auth: {
                    scope: ['ab', 'cat']
                }
            }
        });

        server.inject({ url: '/', headers: { authorization: 'Custom steve' } }, function (res) {

            expect(res.statusCode).to.equal(200);
            done();
        });
    });

[poeticninja]

Looks like Hapi is using the Hoek intersect method for comparing two arrays. But I do not believe that is the intended goal. It should just do a contains. Possibly like lodash.contains? This would let us know if the item is in the array. Maybe in Hoek we add that method? if we add that method it would make the scope check only one or statement instead of two.

I am talking about lines 265-267 in file auth.js

[poeticninja]

Nice. Thanks!