server.method breaking change

[dhm116]

It appears there is a breaking change to how methods added via server.method or plugin.method are handled between v6.7.1 and 6.8.0 - v6.7.1...v6.8.0#diff-89cf897642f2ca735f4178aa8760dec6R1282

It appears as though registered methods need to accept and invoke a callback now. I would consider this a breaking change, especially since the methods we were registering were using promises and now requires un-wrapping the promise to invoke the callback and wrapping the callback results in a promise.

I suppose this relates to #1930 in that it wasn't apparent this behavior had changed.

[hueniverse]

It was a bug of omission. The documents always made it clear that methods must use callbacks. Also, there really is no point in using server methods if you are not going to use them with the callback because you might as well just use good old plain node modules to share them as utilities.

Because you were not using it as specified, I don't consider this a change that merits a major version bump, but I did flag it as breaking change and linked to the version so it will show up in the lists.

[dhm116]

Cool, thanks for the clarification 👍