-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Closed
Labels
breaking changesChange that can breaking existing codeChange that can breaking existing codenon issueIssue is not a problem or requires changesIssue is not a problem or requires changes
Milestone
Description
It appears there is a breaking change to how methods added via server.method
or plugin.method
are handled between v6.7.1 and 6.8.0 - v6.7.1...v6.8.0#diff-89cf897642f2ca735f4178aa8760dec6R1282
It appears as though registered methods need to accept and invoke a callback now. I would consider this a breaking change, especially since the methods we were registering were using promises and now requires un-wrapping the promise to invoke the callback and wrapping the callback results in a promise.
I suppose this relates to #1930 in that it wasn't apparent this behavior had changed.
Metadata
Metadata
Assignees
Labels
breaking changesChange that can breaking existing codeChange that can breaking existing codenon issueIssue is not a problem or requires changesIssue is not a problem or requires changes