New Event for request.log

[arb]

I think we should change the event that is emitted from request.log(). Currently, "request" is emitted multiple times per request so if your client is only interested in the call to log, they need to do some filtering.

Maybe "requestlog" or something.

Relates to hapijs/good#190

[hueniverse]

What you are asking is to turn off the internal logging events?

[arb]

No I want request.log() to do either of these things:

1. emit a different event ("requestlog" for example) instead of "request" when request.log() is called. (breaking change)
2. emit an additional event ("requestlog" for example) in addition to "request" when request.log() is called. (non-breaking change)

Currently there isn't a clean way to capture "request" events that originate from request.log() if clients are only interested in that single event and not all of the "request" events.

[hueniverse]

Everything calls request.log(). I think you are trying to make a difference between the ones called by hapi internally and the ones called by the user.

[arb]

Yeah it would be nice to not have to rely on tags to figure out the user ones... what about leaving request.log alone and add request.message() (or something) which could call request.log but with something indicating it was user initiated and either raise an additional event or send something in the payload that could be reliably filtered with?

[nlf]

For my own logging, I've been checking for the 'hapi' tag in request log events and assuming those are internal and filtering them out.. It's not perfect, but it's done most of the job.

That said, having a different event would be super useful rather than relying on filtering based on random assumptions made about internal messages.

[lock]

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.