Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin dependencies error message changed #2246

Closed
csrl opened this issue Dec 3, 2014 · 1 comment
Closed

plugin dependencies error message changed #2246

csrl opened this issue Dec 3, 2014 · 1 comment
Assignees
Labels
Milestone

Comments

@csrl
Copy link

@csrl csrl commented Dec 3, 2014

Between rc4 and rc5 the plugin dependency exception message changed.

from
Plugin --deps1 missing dependency --deps2 in connection: http://localhost:0
to
Plugin --deps1 missing dependency --deps2 in connection: localhost:0

Notice the removal of http://

Not a big deal, and if it was intentional, then I'll go ahead and update the test code in glue which was expecting the http:// although that test code should be part of hapi not glue.

@hueniverse hueniverse added the bug label Dec 3, 2014
@hueniverse hueniverse added this to the 8.0.0 milestone Dec 3, 2014
@hueniverse hueniverse self-assigned this Dec 3, 2014
@hueniverse hueniverse closed this in e94816d Dec 3, 2014
@hueniverse
Copy link
Contributor

@hueniverse hueniverse commented Dec 3, 2014

So... the scheme missing is a bug due to some internal evolution of the uri value. This is fixed. The :0 part is no longer included when the port is 0 so you still need to change the error to not include :0 at the end.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants