Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setting undefined headers on transmit #2352

Closed
stephen-bartell opened this issue Jan 15, 2015 · 6 comments
Closed

setting undefined headers on transmit #2352

stephen-bartell opened this issue Jan 15, 2015 · 6 comments
Assignees
Labels
Milestone

Comments

@stephen-bartell
Copy link
Contributor

@stephen-bartell stephen-bartell commented Jan 15, 2015

I'm not sure of what the policy is re bugs due to fixes in iojs which aren't released yet in node (which may or may not be released soon).

heres one. the transmit module allows undefined headers to be set here https://github.com/hapijs/hapi/blob/master/lib/transmit.js#L250.

related issue for context nodejs/node#450

@hueniverse
Copy link
Contributor

@hueniverse hueniverse commented Jan 17, 2015

First, hapi is only targeting the Joyent distribution of node. This is largely logistical until it is easy to setup travis to test with both distributions.

Second, I am not following what's the issue here. The framework doesn't care what you put in headers so just stop setting undefined. What am I missing?

@hueniverse hueniverse self-assigned this Jan 17, 2015
@hueniverse hueniverse closed this Feb 9, 2015
@AdriVanHoudt
Copy link
Contributor

@AdriVanHoudt AdriVanHoudt commented Feb 9, 2015

@hueniverse
Copy link
Contributor

@hueniverse hueniverse commented Feb 9, 2015

@AdriVanHoudt already done.

@AdriVanHoudt
Copy link
Contributor

@AdriVanHoudt AdriVanHoudt commented Feb 9, 2015

@hueniverse cool! Didn't notice when the last post was posted sorry.

@rainabba
Copy link

@rainabba rainabba commented Aug 14, 2015

@hueniverse I just landed here because (as I've seen a few times now), a plugin is setting a header with value of undefined and the resulting error has no reference to the plugin which makes it VERY hard to debug. Any suggestions on how to best do that? In my case, I was working with a plugin that modified headers so it wasn't hard to figure out which and then search for ".header", but if I'd been changing something at another level, I would have had no idea where to even begin looking.

@hueniverse hueniverse reopened this Aug 15, 2015
@hueniverse
Copy link
Contributor

@hueniverse hueniverse commented Aug 15, 2015

We'll need to address it as part of node.js 4.0 release testing.

@hueniverse hueniverse added bug and removed non issue labels Oct 1, 2015
@hueniverse hueniverse added this to the 10.2.0 milestone Oct 1, 2015
@hueniverse hueniverse closed this in 8221ab1 Oct 1, 2015
@lock lock bot locked as resolved and limited conversation to collaborators Jan 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants