Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method name RegExp #2401

Closed
gagle opened this issue Feb 11, 2015 · 1 comment
Closed

Method name RegExp #2401

gagle opened this issue Feb 11, 2015 · 1 comment
Assignees
Labels
Milestone

Comments

@gagle
Copy link

@gagle gagle commented Feb 11, 2015

Currently, the method name is validated with this regexp:

/^[a-zA-Z]\w*(?:\.[a-zA-Z]\w*)*$/

You could allow any identifier name, that is, any string starting with $ or _. For instance, I need to create a method with a name starting with underscore and I can't.

Error: Invalid name: _common.injectQueryClientAndAncestors
@hueniverse
Copy link
Contributor

@hueniverse hueniverse commented Feb 16, 2015

I'll take a PR.

@hueniverse hueniverse assigned hueniverse and unassigned hueniverse Feb 16, 2015
@hueniverse hueniverse self-assigned this Feb 20, 2015
@hueniverse hueniverse added this to the 8.3.0 milestone Feb 20, 2015
@lock lock bot locked as resolved and limited conversation to collaborators Jan 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants