Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hapijs/qs to 4.0.0 from 2.4.2 #2623

Closed
hueniverse opened this issue Jul 1, 2015 · 4 comments
Closed

Update hapijs/qs to 4.0.0 from 2.4.2 #2623

hueniverse opened this issue Jul 1, 2015 · 4 comments
Assignees
Milestone

Comments

@hueniverse
Copy link
Contributor

@hueniverse hueniverse commented Jul 1, 2015

Planning on including this in 8.8.0 and not in a major version as the changes in qs while breaking for some qs use cases, should not be breaking here. I will tag the issue as breaking changes just in case someone does have an issue with this to make finding the cause easier.

@hueniverse hueniverse self-assigned this Jul 1, 2015
@hueniverse hueniverse added this to the 8.8.0 milestone Jul 1, 2015
@hueniverse
Copy link
Contributor Author

@hueniverse hueniverse commented Jul 1, 2015

@nlf so this breaks some of the tests because the deep comparison fails. I am not sure what's the right way to fix this. I can force the object back into prototype but that means basically overriding members (same bug 3.x was trying to fix) or I we need to change the tests or assertion module to ignore prototype somehow.

Thoughts?

@nlf
Copy link
Member

@nlf nlf commented Jul 1, 2015

Code.expect has the ability to pass options to Hoek.deepEqual, which allows you to pass { prototype: false } and not compare prototypes, but this still feels hackish. I'm trying to think of a better solution to the overall problem in qs.

@arb
Copy link
Contributor

@arb arb commented Jul 1, 2015

I added that feature to address this very problem.

@nlf
Copy link
Member

@nlf nlf commented Jul 2, 2015

should update to 4.0.0 instead of 3.1.0 now, should resolve any issues you had.

@hueniverse hueniverse changed the title Update hapijs/qs to 3.1.0 from 2.4.2 Update hapijs/qs to 4.0.0 from 2.4.2 Jul 3, 2015
@hueniverse hueniverse closed this in cf267f9 Jul 3, 2015
@lock lock bot locked as resolved and limited conversation to collaborators Jan 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants