Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vary accept-encoding header not always set for compressible content #2641

Closed
kanongil opened this issue Jul 12, 2015 · 0 comments
Closed

Vary accept-encoding header not always set for compressible content #2641

kanongil opened this issue Jul 12, 2015 · 0 comments
Assignees
Labels
Milestone

Comments

@kanongil
Copy link
Contributor

@kanongil kanongil commented Jul 12, 2015

Currently the accept-encoding header is only added to the vary header when the response contains a content-encoding. This works but can cause intermediate caches to only return the non-encoded response when an initial request does not contain a compatible content-encoding, causing compatible clients to receive non-encoded content.

To fix this, accept-encoding should be added to the vary header to all payload containing responses with compressible content.

@hueniverse hueniverse added the bug label Aug 7, 2015
@hueniverse hueniverse self-assigned this Aug 7, 2015
@hueniverse hueniverse closed this in a112f32 Aug 7, 2015
@hueniverse hueniverse added this to the 9.0.0 milestone Aug 7, 2015
@lock lock bot locked as resolved and limited conversation to collaborators Jan 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants