Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm install hapi misses wreck sub-dependency #2699

Closed
kanongil opened this issue Aug 12, 2015 · 5 comments
Closed

npm install hapi misses wreck sub-dependency #2699

kanongil opened this issue Aug 12, 2015 · 5 comments
Assignees
Labels
bug Bug or defect dependency Update module dependency
Milestone

Comments

@kanongil
Copy link
Contributor

When I run npm install hapi@9.x it does not install wreck even though it is a dependency of subtext. I suspect it is missing from the npm-shrinkwrap.json file.

@kanongil
Copy link
Contributor Author

Note that this issue causes hapi 9.0.0 installs to be completely broken unless you manually npm install wreck, or already had it as a dependency.

> var Hapi = require('hapi');
Error: Cannot find module 'wreck'
    at Function.Module._resolveFilename (module.js:336:15)
    at Function.Module._load (module.js:278:25)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at Object.<anonymous> (/Users/gil/test/node_modules/hapi/node_modules/subtext/lib/index.js:14:13)
    at Module._compile (module.js:460:26)
    at Object.Module._extensions..js (module.js:478:10)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Module.require (module.js:365:17)

@dave-irvine
Copy link

+1 Also getting this issue.

@bricss
Copy link

bricss commented Aug 12, 2015

Same happen to me.

@devinivy
Copy link
Member

PR #2701 seems to fix this for me. Someone mind giving this a whirl other than me? npm install git://github.com/devinivy/hapi.git#9deps should pull it in for you.

@hueniverse hueniverse added bug Bug or defect dependency Update module dependency labels Aug 12, 2015
@hueniverse hueniverse added this to the 9.0.1 milestone Aug 12, 2015
@hueniverse hueniverse self-assigned this Aug 12, 2015
@AdriVanHoudt
Copy link
Contributor

@hueniverse can you close the milestone if this is the only issue in the release (I assume yes since it is on npm) this way the changelog on hapijs.com catches it ;)

@lock lock bot locked as resolved and limited conversation to collaborators Jan 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bug or defect dependency Update module dependency
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants