Decorations not propagated to sibling plugins

[Marsup]

Credits go to @jedireza for finding this one.

Registration order has an impact on decorations access, regardless of the use of server.dependency.
For exemple calling server.views with [Vision, Lout] will work, [Lout, Vision] won't : TypeError: Object [object Object] has no method 'views'.

Decorations are only copied on the initialization of the plugins, so while the server.root is always aware of those decorations, this line will not be propagate the decorators to others.

It seems I have 2 choices here :

• always use server.root.*
• fix it in hapi, by copying again (maybe here) all the decorations from the root

Willing to make a PR if that's the 2nd case.

[hueniverse]

Why is this not an issue of lout needing to wait for vision to load? You are seeing it now because vision is not built in anymore but this isn't new. Before it was still the same problem. You need to wait for after event when vision is loaded.

I am not saying that's the only issue here but that it's not just a matter of supporting random order.

[Marsup]

I am. New Plugin instances are provided to each register, they don't share the same this (though they do share the same root).

[Marsup]

To be even more explicit, I think we should have a similar loop as this one before calling the dependency callback.

[Marsup]

@hueniverse do you want a PR doing what I suggested in OP ?

[hueniverse]

Nah. I need to do a deeper fix.

[Marsup]

Wow, that was simpler than I expected :)

[devinivy]

That commit is sort of delightful.

[hueniverse]

There are some dark corner of this code base :-)