Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support connectionless plugins #2811

Closed
hueniverse opened this issue Oct 2, 2015 · 2 comments
Closed

Support connectionless plugins #2811

hueniverse opened this issue Oct 2, 2015 · 2 comments
Assignees
Labels
Milestone

Comments

@hueniverse
Copy link
Contributor

@hueniverse hueniverse commented Oct 2, 2015

Adds a new plugin attribute connections which when set to false removes the server.connection array and prevents the plugin from performing operations on the connections. This means the plugin operates exclusively on the server and is available to connections added after the plugin was already registered.

@hueniverse hueniverse self-assigned this Oct 2, 2015
@hueniverse hueniverse added this to the 10.2.0 milestone Oct 2, 2015
@hueniverse hueniverse closed this in fb78edf Oct 2, 2015
@devinivy
Copy link
Member

@devinivy devinivy commented Oct 2, 2015

So what exactly would happen if I make a connectionless plugin that calls server.route() then register it to a non-empty selection? It seems like it would silently not do anything. Is there a reason to allow connectionless plugins to be registered to a non-empty selection?

Also might be nice to enumerate or mark the server methods (in documentation) that do not act on a connection so that it's clear what's kosher.

@hueniverse
Copy link
Contributor Author

@hueniverse hueniverse commented Oct 2, 2015

It will throw. The server object you get will have no connections array. Feel free to improve the docs.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants