Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update server root methods when adding 2nd connection #2813

Closed
hueniverse opened this issue Oct 3, 2015 · 1 comment
Closed

Update server root methods when adding 2nd connection #2813

hueniverse opened this issue Oct 3, 2015 · 1 comment
Assignees
@hueniverse
Labels
breaking changes Change that can breaking existing code bug Bug or defect
Milestone
10.2.0

Comments

@hueniverse
Copy link
Contributor

The previous behavior kept the single connection decorations around once additional connections were added which was a bug and clearly against the documented behavior. This might cause existing code to throw an unknown method exception, but the existing code was at best lucky to invoke the right connection method.
@hueniverse hueniverse added the bug Bug or defect label Oct 3, 2015
@hueniverse hueniverse self-assigned this Oct 3, 2015
@hueniverse hueniverse added this to the 10.2.0 milestone Oct 3, 2015
@hueniverse hueniverse added the breaking changes Change that can breaking existing code label Oct 3, 2015
@hueniverse
Copy link
Contributor Author

To keep the same broken behavior change it to: server.connections[0].* where * is inject() etc.

kpdecker added a commit to outmoded/lout that referenced this issue Oct 4, 2015
@kpdecker
Fix failing test due to hapijs/hapi#2813
c120085
kpdecker added a commit to outmoded/lout that referenced this issue Oct 17, 2015
@kpdecker
Fix failing test due to hapijs/hapi#2813
868c9c2
@lock lock bot locked as resolved and limited conversation to collaborators Jan 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hueniverse hueniverse

Labels
breaking changes Change that can breaking existing code bug Bug or defect
Projects
None yet
Milestone
10.2.0
Development

No branches or pull requests
1 participant
@hueniverse