Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace single connection server decorations with assertions #2819

Closed
hueniverse opened this issue Oct 4, 2015 · 2 comments
Closed

Replace single connection server decorations with assertions #2819

hueniverse opened this issue Oct 4, 2015 · 2 comments
Assignees
Labels
breaking changes Change that can breaking existing code feature New functionality or improvement
Milestone

Comments

@hueniverse
Copy link
Contributor

No description provided.

@hueniverse hueniverse added the feature New functionality or improvement label Oct 4, 2015
@hueniverse hueniverse added this to the 10.4.0 milestone Oct 5, 2015
@hueniverse hueniverse self-assigned this Oct 5, 2015
@Marsup
Copy link
Contributor

Marsup commented Oct 5, 2015

Won't it be a breaking change for some people ?

@hueniverse hueniverse added the breaking changes Change that can breaking existing code label Oct 5, 2015
@hueniverse
Copy link
Contributor Author

Maybe I guess. It would be really odd to test if these methods are null and call them if they are not. Otherwise, you get null is not a function today, and a nicer message with this change.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking changes Change that can breaking existing code feature New functionality or improvement
Projects
None yet
Development

No branches or pull requests

2 participants