New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update hapijs/subtext to 2.0.2 from 2.0.0 #2862
Comments
Hi @bpdp, subtext works fine with qs@5.2.0, I've updated the qs dependency in the latest version of subtext. |
Hi @johnbrett - thanks. closing this issue. |
Still happen in 11.0.2. In hapi package.json, the dep is subtext 2.x.x. AFAIK, this should fetch latest version of subtext (2.0.2), but it fetch 2.0.0 instead. Should we put ^2.x.x ? |
No. hapi comes with shrinkwrap. Will need to update it and publish a new version. |
thanks @hueniverse. will wait for that new version |
For us the issue with this is the npm-shirnkwrap.json file specifies subtext 2.0.0 which uses qs@4.x.x but It should specify subtext 2.0.2 so qs@5.2.x from hapijs can be used. I think the 11.0.2 release jusy needs npm shrinkwrap to be run. (Sorry, I'm still learning about npm and how to package things.) |
@hueniverse Could you please release 11.0.3? It is not possible to create a shrinkwrap:
|
No, don't do that. Master is still broken. We need subtext 2.0.2.
|
Installing 11.0.1 complain with this warning:
npm WARN unmet dependency /fakeproject/node_modules/hapi/node_modules/subtext requires qs@'4.x.x' but will load
npm WARN unmet dependency /fakeproject/node_modules/hapi/node_modules/qs,
npm WARN unmet dependency which is version 5.2.0
It was only WARN, but will it be fine?
The text was updated successfully, but these errors were encountered: