Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace node's EventEmitter interface #3294

Closed
hueniverse opened this issue Aug 18, 2016 · 0 comments
Closed

Replace node's EventEmitter interface #3294

hueniverse opened this issue Aug 18, 2016 · 0 comments
Assignees
Labels
breaking changes Change that can breaking existing code feature New functionality or improvement
Milestone

Comments

@hueniverse
Copy link
Contributor

hueniverse commented Aug 18, 2016

The current public interfaces using node's EventEmitter are being switched over to a new implementation that supports many new features including async handlers, counters (not just once), and argument cloning. Over the years we had multiple requests for such features but were limited by node's EventEmitter implementation.

As part of this transition, the following emitter APIs will no longer be supported:

  • newListener and removeListener events
  • listenerCount()
  • defaultMaxListeners
  • eventNames()
  • getMaxListeners()
  • listenerCount()
  • listeners()
  • prependListener()
  • prependOnceListener()
  • setMaxListeners()

In addition, all existing server, request, and response events that are part of the hapi API (e.g. request.raw emitters remain unchanged) will switch to use a single format handler with a fixed number of arguments (vs. the current per-event-type function signature).

@hueniverse hueniverse added feature New functionality or improvement breaking changes Change that can breaking existing code labels Aug 18, 2016
@hueniverse hueniverse added this to the 14.2.1 milestone Aug 18, 2016
@hueniverse hueniverse self-assigned this Aug 18, 2016
@lock lock bot locked as resolved and limited conversation to collaborators Jan 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking changes Change that can breaking existing code feature New functionality or improvement
Projects
None yet
Development

No branches or pull requests

1 participant