Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hapijs/joi to 10.1.0 from 10.0.1 #3416

Closed
hueniverse opened this issue Dec 29, 2016 · 0 comments
Closed

Update hapijs/joi to 10.1.0 from 10.0.1 #3416

hueniverse opened this issue Dec 29, 2016 · 0 comments

Comments

@hueniverse
Copy link
Contributor

@hueniverse hueniverse commented Dec 29, 2016

joi 10.0.0 changed the way non boolean strings are matched against a boolean requirement. Specifically, it stopped casting anything into a boolean. This change was incorrect because literal strings of 'true' and 'false' should still be converted when not using strict mode. This change was properly documented in the hapi v16 release notes but after further review we decided that this was a mistake and joi reverted the behavior. I decided that while this is technically a breaking change because literal true/false strings will now match boolean schema, it is the expected behavior. I've marked this issue as a breaking change but it is attached to a minor release version.

@hueniverse hueniverse added this to the 16.1.0 milestone Dec 29, 2016
@hueniverse hueniverse self-assigned this Dec 29, 2016
@hueniverse hueniverse changed the title Update hapijs/joi to 10.0.4 from 10.0.1 Update hapijs/joi to 10.1.0 from 10.0.1 Dec 29, 2016
@lock lock bot locked as resolved and limited conversation to collaborators Jan 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant