-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Closed
Labels
breaking changesChange that can breaking existing codeChange that can breaking existing codedependencyUpdate module dependencyUpdate module dependency
Milestone
Description
joi 10.0.0 changed the way non boolean strings are matched against a boolean requirement. Specifically, it stopped casting anything into a boolean. This change was incorrect because literal strings of 'true' and 'false' should still be converted when not using strict mode. This change was properly documented in the hapi v16 release notes but after further review we decided that this was a mistake and joi reverted the behavior. I decided that while this is technically a breaking change because literal true/false strings will now match boolean schema, it is the expected behavior. I've marked this issue as a breaking change but it is attached to a minor release version.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
breaking changesChange that can breaking existing codeChange that can breaking existing codedependencyUpdate module dependencyUpdate module dependency