Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reply.entity() will always return null for correct etags #3427

Closed
dypsilon opened this issue Jan 16, 2017 · 1 comment
Closed

reply.entity() will always return null for correct etags #3427

dypsilon opened this issue Jan 16, 2017 · 1 comment
Assignees
Labels
Milestone

Comments

@dypsilon
Copy link
Contributor

@dypsilon dypsilon commented Jan 16, 2017

The test fixture in test/reply.js is not correct because a valid etag looks like this:

server.inject({ url: '/', headers: { 'if-none-match': '"abc"' } })

Please note the quotes around abc. Particularly this is how the browsers send them. If you change this line to a correct etag the count will always be 2 and the test will fail.

@kanongil
Copy link
Contributor

@kanongil kanongil commented Mar 6, 2017

Wow, good catch. We should fix this.

MDN reference: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/If-None-Match

@hueniverse hueniverse self-assigned this May 29, 2017
@hueniverse hueniverse added the bug label May 29, 2017
@hueniverse hueniverse added this to the 16.1.2 milestone May 29, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants