TypeError: Cannot set property 'hostname' of undefined

[JetLua]

/mnt/npm/lib/node_modules/hapi/lib/request.js:229
        this.info.hostname = url.hostname;
                           ^

TypeError: Cannot set property 'hostname' of undefined
    at internals.Request._setUrl (/mnt/npm/lib/node_modules/hapi/lib/request.js:229:28)
    at new internals.Request (/mnt/npm/lib/node_modules/hapi/lib/request.js:83:10)
    at module.exports.internals.Generator.internals.Generator.request (/mnt/npm/lib/node_modules/hapi/lib/request.js:31:21)
    at Server.<anonymous> (/mnt/npm/lib/node_modules/hapi/lib/connection.js:260:48)
    at emitTwo (events.js:125:13)
    at Server.emit (events.js:213:7)
    at parserOnIncoming (_http_server.js:601:12)
    at HTTPParser.parserOnHeadersComplete (_http_common.js:116:23)

• node version: 8.0.0
• hapi version: 16.4.1
• os: debian 8

[Marsup]

How about a way to reproduce this ?

[JetLua]

I am also looking for how to reproduce. It always runs normally for a while, and then this error occurs.

[AJamesPhillips]

@JetLua it might be a binding issue, what is the value of this when it fails. Perhaps put it in a try catch and log the value of this. You might find its' the node global value.

[JetLua]

@AJamesPhillips Thanks.

I added a piece of code.

lib/request.js

Currently running normally, no output.

[AdriVanHoudt]

I'm getting the same error with latest hapi
happens around every 30min, I also added a log to check what is going on
will report back when I got something

[AJamesPhillips]

Just curious (no obligation to answer):

• how many connections are you running @AdriVanHoudt and @JetLua ?
• what plugins are you using? (and have you changed any of their versions or is it only hapi you changed?)
• what version of hapi was it ok on?
• I assume the this.info error is occurring in a route request handler?

[AdriVanHoudt]

Still looking but has probably to do with calling https://github.com/hapijs/hapi/blob/master/lib/request.js#L83
before https://github.com/hapijs/hapi/blob/master/lib/request.js#L147

working on a reproducible case :P

[arb]

How are you starting your server and registering plugins?

[AdriVanHoudt]

Not different from hapi 16.2 :P
I think this is something that just came up since hapi never accessed this.info inside Request like that before and every case I've tried so far worked correctly. I will add some more logging and wait for that to get a reproducible case

[JetLua]

@AJamesPhillips @AdriVanHoudt

With the output：

{ _eventListeners: 
   { finish: { handlers: null, flags: [Object] },
     peek: { handlers: null, flags: [Object] },
     disconnect: { handlers: null, flags: [Object] } },
  _notificationsQueue: [],
  _eventsProcessing: false,
  _sourcePodiums: [],
  _bench: { ts: 9712062273.021809 },
  connection: 
   { _eventListeners: 
      { route: [Object],
        'request-internal': [Object],
        request: [Object],
        'request-error': [Object],
        response: [Object],
        tail: [Object] },
     _notificationsQueue: [],
     _eventsProcessing: false,
     _sourcePodiums: [ [Object], [Object] ],
     settings: 
      { compression: true,
        router: [Object],
        routes: [Object],
        port: 8000,
        labels: [],
        autoListen: true },
     server: 
      { _settings: [Object],
        _caches: [Object],
        _handlers: {},
        _methods: [Object],
        _events: [Object],
        _dependencies: [],
        _registrations: {},
        _heavy: [Object],
        _mime: [Object],
        _replier: [Object],
        _requestor: [Object],
        _decorations: {},
        decorations: [Object],
        _plugins: {},
        _app: {},
        _registring: false,
        _state: 'started',
        _extensionsSeq: 0,
        _extensions: [Object],
        _eventListeners: [Object],
        _notificationsQueue: [],
        _eventsProcessing: false,
        _sourcePodiums: [],
        _parent: null,
        root: [Circular],
        app: {},
        connections: [Array],
        load: [Object],
        methods: {},
        mime: [Object],
        plugins: {},
        settings: [Object],
        version: '16.4.1',
        realm: [Object],
        auth: [Object],
        cache: [Object],
        info: [Object],
        listener: [Object],
        registrations: {} },
     type: 'tcp',
     _started: true,
     _connections: { '80.82.78.38:36636': [Object] },
     _onConnection: [Function],
     registrations: {},
     _extensions: 
      { onRequest: [Object],
        onPreAuth: [Object],
        onPostAuth: [Object],
        onPreHandler: [Object],
        onPostHandler: [Object],
        onPreResponse: [Object] },
     _requestCounter: { value: 10150, min: 10000, max: 99999 },
     _load: { _process: [Object], settings: [Object] },
     _compression: { encodings: [Array], _encoders: [Object], _decoders: [Object] },
     states: { settings: [Object], cookies: {}, names: [] },
     auth: 
      { connection: [Circular],
        _schemes: {},
        _strategies: {},
        settings: [Object],
        api: {} },
     _router: 
      { settings: [Object],
        routes: [Object],
        ids: {},
        vhosts: null,
        specials: [Object] },
     plugins: {},
     app: {},
     listener: 
      Server {
        domain: null,
        _events: [Object],
        _eventsCount: 4,
        _maxListeners: undefined,
        _connections: 1,
        _handle: [Object],
        _usingSlaves: false,
        _slaves: [],
        _unref: false,
        allowHalfOpen: true,
        pauseOnConnect: false,
        httpAllowHalfOpen: false,
        timeout: 120000,
        keepAliveTimeout: 5000,
        _pendingResponseData: 0,
        maxHeadersCount: null,
        _connectionKey: '4:0.0.0.0:8000',
        [Symbol(asyncId)]: 17 },
     info: 
      { created: 1496807385231,
        started: 1496807385264,
        host: 'iZ23hugf5kzZ',
        port: 8000,
        protocol: 'http',
        id: 'iZ23hugf5kzZ:15365:j3mggy33',
        uri: 'http://iZ23hugf5kzZ:8000',
        address: '0.0.0.0' } },
  server: 
   { _settings: 
      { debug: [Object],
        load: [Object],
        mime: null,
        useDomains: true,
        connections: [Object] },
     _caches: { _default: [Object] },
     _handlers: {},
     _methods: { server: [Circular], methods: {}, _normalized: {} },
     _events: 
      { _eventListeners: [Object],
        _notificationsQueue: [],
        _eventsProcessing: false,
        _sourcePodiums: [Array] },
     _dependencies: [],
     _registrations: {},
     _heavy: 
      { settings: [Object],
        _eventLoopTimer: null,
        _loadBench: [Object],
        load: [Object] },
     _mime: Mimos { _byType: [Object], _byExtension: [Object] },
     _replier: { _decorations: null },
     _requestor: { _decorations: null },
     _decorations: {},
     decorations: { request: [], reply: [], server: [] },
     _plugins: {},
     _app: {},
     _registring: false,
     _state: 'started',
     _extensionsSeq: 0,
     _extensions: 
      { onPreStart: [Object],
        onPostStart: [Object],
        onPreStop: [Object],
        onPostStop: [Object] },
     _eventListeners: 
      { route: [Object],
        'request-internal': [Object],
        request: [Object],
        'request-error': [Object],
        response: [Object],
        tail: [Object],
        log: [Object],
        start: [Object],
        stop: [Object] },
     _notificationsQueue: [],
     _eventsProcessing: false,
     _sourcePodiums: [],
     _parent: null,
     root: [Circular],
     app: {},
     connections: [ [Object] ],
     load: { eventLoopDelay: 0, heapUsed: 0, rss: 0 },
     methods: {},
     mime: Mimos { _byType: [Object], _byExtension: [Object] },
     plugins: {},
     settings: 
      { debug: [Object],
        load: [Object],
        mime: null,
        useDomains: true,
        connections: [Object] },
     version: '16.4.1',
     realm: 
      { _extensions: [Object],
        modifiers: [Object],
        plugin: '',
        pluginOptions: {},
        plugins: {},
        settings: [Object] },
     auth: 
      { default: [Function: default],
        scheme: [Function: scheme],
        strategy: [Function: strategy],
        test: [Function: test],
        api: {} },
     cache: { [Function: policy] provision: [Function] },
     info: 
      { created: 1496807385231,
        started: 1496807385264,
        host: 'iZ23hugf5kzZ',
        port: 8000,
        protocol: 'http',
        id: 'iZ23hugf5kzZ:15365:j3mggy33',
        uri: 'http://iZ23hugf5kzZ:8000',
        address: '0.0.0.0' },
     listener: 
      Server {
        domain: null,
        _events: [Object],
        _eventsCount: 4,
        _maxListeners: undefined,
        _connections: 1,
        _handle: [Object],
        _usingSlaves: false,
        _slaves: [],
        _unref: false,
        allowHalfOpen: true,
        pauseOnConnect: false,
        httpAllowHalfOpen: false,
        timeout: 120000,
        keepAliveTimeout: 5000,
        _pendingResponseData: 0,
        maxHeadersCount: null,
        _connectionKey: '4:0.0.0.0:8000',
        [Symbol(asyncId)]: 17 },
     registrations: {} },
  url: 
   Url {
     protocol: 'http:',
     slashes: true,
     auth: null,
     host: 'www.baidu.com',
     port: null,
     hostname: 'www.baidu.com',
     hash: null,
     search: '',
     query: {},
     pathname: '/cache/global/img/gs.gif',
     path: '/cache/global/img/gs.gif',
     href: 'http://www.baidu.com/cache/global/img/gs.gif' },
  query: {},
  path: '/cache/global/img/gs.gif',
  method: null,
  mime: null,
  setUrl: [Function],
  setMethod: [Function] }

[JetLua]

In the output above,
I'm a little confused:

this.url.host: 'www.baidu.com'
this.server.info.host: 'iZ23hugf5kzZ'
this.connection.info.host: 'iZ23hugf5kzZ'
//without: this.info

Start the script:

const
    hapi = require('hapi'),
    ssr = require('./lib/ssr'),
    api = require('./lib/api'),
    app = new hapi.Server()

app.connection({port: 8000})

ssr(app)
api(app)

app.start()

[AJamesPhillips]

@JetLua more context please. Those with more experience of hapi might be able to solve it from what you've posted but the following would be very useful to know:

1. The output you posted (2 above comments) is the result of running the scripts (above) and so is the what you saw from the console.log(this) line?
2. What are the scripts you're running in ./lib/ssr and ./lib/api, you'll need to reduce them down to something all in one file and not more than a hundred lines. Please see: http://sscce.org/

[AdriVanHoudt]

I got some more info and tried all the test cases but could not reproduce

{
	"__error_callsites": [{}, {}, {}, {}, {}, {}, {}, {}, {}],
	"url": {
		"href": "http://www.baidu.com/",
		"path": "/",
		"pathname": "/",
		"query": {},
		"search": "",
		"hash": null,
		"hostname": "www.baidu.com",
		"port": null,
		"host": "www.baidu.com",
		"auth": null,
		"slashes": true,
		"protocol": "http:"
	},
	"orig": "HTTP://www.baidu.com/",
	"message": "this.info not set while trying to set hostname to www.baidu.com",
	"stack": "Error: this.info not set while trying to set hostname to www.baidu.com\n    at internals.Request.internals.Request._setUrl (/home/adri/Server/node_modules/hapi/lib/request.js:230:12)\n    at new internals.Request.options (/home/adri/Server/node_modules/hapi/lib/request.js:83:10)\n    at internals.Generator.request (/home/adri/Server/node_modules/hapi/lib/request.js:31:21)\n    at Server.<anonymous> (/home/adri/Server/node_modules/hapi/lib/connection.js:260:48)\n    at emitTwo (events.js:87:13)\n    at Server.emit (events.js:172:7)\n    at Server.emit (/home/adri/Server/node_modules/opbeat/lib/instrumentation/http-shared.js:54:19)\n    at HTTPParser.parserOnIncoming [as onIncoming] (_http_server.js:539:12)\n    at HTTPParser.parserOnHeadersComplete (_http_common.js:97:23)"
}

Weirdly it also shows baidu :D
url is the new url object trying to be set and orig is what is given to _setUrl before anything happens