Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedbacks on core 'http2' module #3584

Closed
mcollina opened this issue Sep 23, 2017 · 10 comments
Closed

Feedbacks on core 'http2' module #3584

mcollina opened this issue Sep 23, 2017 · 10 comments
Assignees
Labels
support Questions, discussions, and general support

Comments

@mcollina
Copy link

mcollina commented Sep 23, 2017

Can one of you check out the experimental 'http2' module from core?
The docs are here: https://nodejs.org/api/http2.html.

If would be good to know if we have to change anything to better support the integration with Hapi.

We plan to make require('http2') available without a flag in Node 9, and move it out of experimental before Node 10.

cc @jasnell

@hueniverse
Copy link
Contributor

hueniverse commented Sep 24, 2017

Probably another week before I can get into it with v17 in full dev right now.

@hueniverse hueniverse self-assigned this Sep 24, 2017
@mcollina
Copy link
Author

mcollina commented Sep 24, 2017

There is no hurry, just let us know here or open issues on nodejs/node.

@hueniverse hueniverse added support Questions, discussions, and general support and removed discussion labels Nov 14, 2017
@mnot
Copy link

mnot commented Nov 29, 2017

Where's the best place to leave feedback / ask questions?

@mcollina
Copy link
Author

mcollina commented Nov 30, 2017

Here or in nodejs/node.

@hueniverse
Copy link
Contributor

hueniverse commented Nov 30, 2017

@mnot about the node http2 module in general or it's relation with hapi?

@mnot
Copy link

mnot commented Nov 30, 2017

In general; I'll give it over there. Thanks.

@hueniverse
Copy link
Contributor

hueniverse commented Aug 2, 2018

I don't see an HTTP2 native support happening in the near future as there are no clear use cases driving this. I know some people are using hapi with the new HTTP2 server but I don't really have enough experience to provide feedback. I hope this will change but I don't really want to build HTTP2 features without some kind of business driver...

@chrisdavies
Copy link

chrisdavies commented Jan 16, 2019

Hi @hueniverse I work on the Elastic Kibana team (but I don't claim to speak for them).

We've currently got a feature that uses websockets mostly because Hapi doesn't have http2 support. Basically, we've got a feature (Canvas) that allows our end-users to build fancy, custom scripted UIs. The scripting language generally needs to communicate with the server. So, if they build a UI with loads of little components, each with a custom script, it gets really chatty. This isn't ideal over HTTP/1, but HTTP/2 or websockets mitigates the problem.

I'd personally prefer to use HTTP/2 for this, as I think it would mean simpler code for us. Happy to discuss in more detail, if you're interested.

@hueniverse
Copy link
Contributor

hueniverse commented Jan 18, 2019

@chrisdavies feel free to ping me on the hapihour slack channel. I'd need more context to understand how you want to use http/2 with hapi.

@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
support Questions, discussions, and general support
Projects
None yet
Development

No branches or pull requests

4 participants