prerequisite returning empty string yields null on the pre object of request

[twhitbeck]

Are you sure this is an issue with hapi or are you just looking for some help?

Definitely with hapi, although I don't know this is a bug or just undocumented behavior. It's unexpected, at the very least.

What are you trying to achieve or the steps to reproduce?

When a route prerequisite replies with an empty string, the resulting property assigned to request.pre is null, not the empty string as I was expecting.

This is because of

hapi/lib/response.js

Lines 82 to 87 in ec5eaca

	if (source === null ||
	source === undefined ||
	source === '') {
	source = null;
	}

What was the result you received?

null

What did you expect?

empty string

Context

• node version: 8.8.0
• hapi version: 16.6.2
• os: Debian

[AdriVanHoudt]

@hueniverse is this a bug as in it should return ''? If so would you take a PR?

[Marsup]

He assigned himself, unlikely.

[AdriVanHoudt]

totally missed that, don't mind me, carry on ^^

[hueniverse]

I am not sure yet. This came up in nes as well where empty payload is sent as null. I need to come up with a consistent way to address it. I think I am not going to force '' into null anymore, but still treat both as empty payload.

[lock]

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.