Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors in "onPostStart" ext leave listener active forever #3708

Closed
kanongil opened this issue Dec 7, 2017 · 1 comment
Closed

Errors in "onPostStart" ext leave listener active forever #3708

kanongil opened this issue Dec 7, 2017 · 1 comment
Assignees
Labels
Milestone

Comments

@kanongil
Copy link
Contributor

@kanongil kanongil commented Dec 7, 2017

Eg. add this listener, and start() the server:

server.ext('onPostStart', () => {

    throw new Error('bye bye');
});

This will leave the server in phase: 'invalid' and started: false. This causes a stop() to skip unlistening.

@hueniverse hueniverse self-assigned this Dec 20, 2017
@hueniverse hueniverse added the bug label Dec 20, 2017
@hueniverse hueniverse added this to the 17.1.2 milestone Dec 20, 2017
@lock
Copy link

@lock lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants