Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server.control() #3767

Closed
hueniverse opened this issue Mar 30, 2018 · 3 comments
Closed

server.control() #3767

hueniverse opened this issue Mar 30, 2018 · 3 comments
Assignees
Labels
Milestone

Comments

@hueniverse
Copy link
Contributor

@hueniverse hueniverse commented Mar 30, 2018

Allow linking servers to start/stop together.

@hueniverse hueniverse added this to the 17.2.4 milestone Mar 30, 2018
@hueniverse hueniverse self-assigned this Mar 30, 2018
@kanongil
Copy link
Contributor

@kanongil kanongil commented Mar 31, 2018

This implementation is a bit naive, and can put the set of servers into an undefined state, if one eg. of the controlled servers throws an error during start. Or if the primary server throws an early error during stop, the controlled servers won't be stopped.

See my implementation here for a safer start implementation: https://github.com/kanongil/exiting/blob/master/lib/index.js#L238

@hueniverse
Copy link
Contributor Author

@hueniverse hueniverse commented Mar 31, 2018

I generally treat any error in star/stop/initialize as a dead end. In this age of containers, you should log and dispose. I am not sure I want to add the complexity which is never going to be 100% safe and predictable. This is especially true with pre/post server extensions which can also error.

I don't think this implementation is any worse than the multi-connection start/stop we had before in v16.

@lock
Copy link

@lock lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants