Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v16 commercial license version #3933

Closed
hueniverse opened this issue Mar 21, 2019 · 1 comment
Closed

v16 commercial license version #3933

hueniverse opened this issue Mar 21, 2019 · 1 comment
Assignees
@hueniverse
Labels
breaking changes Change that can breaking existing code lts Backport for maintained old version
Milestone
16.8.0

Comments

@hueniverse
Copy link
Contributor

hueniverse commented Mar 21, 2019 •
edited
Loading

The v16.8.0 release includes a breaking change:

  • joi was updated to commercial version 12 which replaced isemail with address. This changes the options available when validating emails via Joi.string().email().
@hueniverse hueniverse added the lts Backport for maintained old version label Mar 21, 2019
@hueniverse hueniverse self-assigned this Mar 21, 2019
@hueniverse hueniverse added this to the 16.8.0 milestone Mar 21, 2019
hueniverse added a commit that referenced this issue Mar 25, 2019
@hueniverse
Initial conversion. For #3933
f25bb75
hueniverse added a commit that referenced this issue Mar 25, 2019
@hueniverse
Fix validation and test. For #3933
dddc6db
hueniverse added a commit that referenced this issue Mar 25, 2019
@hueniverse
Fix tests. Closes #3933
835b841
@hueniverse hueniverse mentioned this issue Mar 25, 2019
Closed
@hueniverse hueniverse added the breaking changes Change that can breaking existing code label Mar 25, 2019
@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hueniverse hueniverse

Labels
breaking changes Change that can breaking existing code lts Backport for maintained old version
Projects
None yet
Milestone
16.8.0
Development

No branches or pull requests
1 participant
@hueniverse