Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise list of hop-by-hop headers #3943

Closed
l-hedgehog opened this issue Apr 12, 2019 · 2 comments

Comments

Projects
None yet
3 participants
@l-hedgehog
Copy link

commented Apr 12, 2019

The list of hop-by-hop headers in #3621 are taken from rfc2616, and there's Errata 4522 which says

Trailers (with a s) does not seem to a header field, just a keyword for TE.
I think that Trailer (without a s) is expected here.

I think the list here should be updated accordingly.

You might also want to take these discussions 1 2 about the missing of such a list in updated http/1.1 rfc723* into consideration.

How I found this:

I'm using hapijs/h2o2 to proxy request to hapi-auth-hawk protected endpoint, but after upgrading from node 8 to 10, I'm getting an ERR_HTTP_TRAILER_INVALID error, seemingly from the removal of "transfer-encoding" but not "trailer".

l-hedgehog referenced this issue Apr 12, 2019

@hueniverse hueniverse self-assigned this Apr 19, 2019

@hueniverse hueniverse added the bug label Apr 19, 2019

@hueniverse hueniverse added this to the 18.3.1 milestone Apr 19, 2019

@hueniverse

This comment has been minimized.

Copy link
Member

commented Apr 19, 2019

@mnot Beyond fixing the typo, would you recommend making other changes to the code here:
https://github.com/hapijs/hapi/blob/master/lib/response.js#L15

@mnot

This comment has been minimized.

Copy link

commented Apr 23, 2019

You appear to be removing headers listed in Connection, so you should be good. There's a discussion at httpwg/http-core#165 that might touch on this in the revised specs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.