Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an insecureAgent when maxSockets is set, closes #1512 #1551

Merged
merged 2 commits into from Apr 4, 2014

Conversation

@nlf
Copy link
Member

@nlf nlf commented Apr 3, 2014

Turns out the issue is if you pass an agent to https.request it ignore the rejectUnauthorized setting, so you need an agent that has rejectUnauthorized set.

@@ -44,7 +44,10 @@ exports.handler = function (route, options) {
rejectUnauthorized: settings.rejectUnauthorized
Copy link
Contributor

@hueniverse hueniverse Apr 4, 2014

Do we still need this?

Copy link
Member Author

@nlf nlf Apr 4, 2014

Yes. If maxSockets is not specified the agents aren't created or used, and so the rejectUnauthorized has to exist here in that case. —
Nathan LaFreniere

On Thu, Apr 3, 2014 at 11:28 PM, Eran Hammer notifications@github.com
wrote:

@@ -44,7 +44,10 @@ exports.handler = function (route, options) {
rejectUnauthorized: settings.rejectUnauthorized

Do we still need this?

Reply to this email directly or view it on GitHub:
https://github.com/spumko/hapi/pull/1551/files#r11284216

Copy link
Contributor

@hueniverse hueniverse Apr 4, 2014

Should add a comment next to that line // In case maxSockets is not specified

@hueniverse hueniverse added the bug label Apr 4, 2014
@hueniverse hueniverse added this to the 3.2.0 milestone Apr 4, 2014
@hueniverse hueniverse self-assigned this Apr 4, 2014
hueniverse pushed a commit that referenced this issue Apr 4, 2014
add an insecureAgent when maxSockets is set, closes #1512
@hueniverse hueniverse merged commit 288c693 into master Apr 4, 2014
1 check was pending
@nlf nlf deleted the 1512/rejectUnauthorized branch Apr 8, 2014
@lock lock bot locked as resolved and limited conversation to collaborators Jan 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants