Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow defaultExtension #1567

Merged
merged 5 commits into from Apr 24, 2014
Merged

allow defaultExtension #1567

merged 5 commits into from Apr 24, 2014

Conversation

@chadkouse
Copy link
Contributor

@chadkouse chadkouse commented Apr 11, 2014

seems like the code still allows for this, but it doesn't pass validation.

@@ -107,7 +107,8 @@ internals.server = {
}),
tls: Joi.object().allow(null),
views: internals.viewSchema({
engines: Joi.object().required()
engines: Joi.object().required(),
defaultExtension: Joi.string()
Copy link
Contributor

@hueniverse hueniverse Apr 11, 2014

Should this go in viewSchema()?

Copy link
Contributor Author

@chadkouse chadkouse Apr 11, 2014

If you say so - I don't really know.. I'm new here :)

@hueniverse hueniverse added the bug label Apr 11, 2014
@hueniverse hueniverse self-assigned this Apr 11, 2014
@hueniverse hueniverse added this to the 4.1.0 milestone Apr 11, 2014
@hueniverse
Copy link
Contributor

@hueniverse hueniverse commented Apr 11, 2014

Can you add a test that shows the bug is resolved?

@chadkouse
Copy link
Contributor Author

@chadkouse chadkouse commented Apr 11, 2014

done!

hueniverse pushed a commit that referenced this issue Apr 24, 2014
@hueniverse hueniverse merged commit eb0da4b into hapijs:master Apr 24, 2014
1 check passed
@chadkouse chadkouse deleted the schema branch Apr 25, 2014
@chadkouse chadkouse restored the schema branch Apr 25, 2014
@lock lock bot locked as resolved and limited conversation to collaborators Jan 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants