Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Hapi cli to enable loading a module before loading hapi #1622

Merged
merged 7 commits into from May 18, 2014

Conversation

@dacbd
Copy link
Contributor

@dacbd dacbd commented May 6, 2014

The reason for adding is to allow the loading of a metrics modules such as newrelic before anything else critical, this could also be useful for other metrics gathering modules as well.

@hueniverse hueniverse self-assigned this May 8, 2014
var extras = internals.argv.require;

if (!extras) {

Copy link
Member

@geek geek May 13, 2014

no need for the newlines after if

@dacbd
Copy link
Contributor Author

@dacbd dacbd commented May 13, 2014

removed

@dacbd
Copy link
Contributor Author

@dacbd dacbd commented May 13, 2014

@wpreul do you have travis rebuild option on this, I can't seem to find it if it is available to me...

@geek
Copy link
Member

@geek geek commented May 13, 2014

Tried a rebuild... no luck... can you repro locally?

@dacbd
Copy link
Contributor Author

@dacbd dacbd commented May 13, 2014

There we go :)

@hueniverse hueniverse removed their assignment May 13, 2014
@hueniverse hueniverse added this to the 4.1.5 milestone May 18, 2014
@hueniverse hueniverse self-assigned this May 18, 2014
hueniverse pushed a commit that referenced this issue May 18, 2014
Extend Hapi cli to enable loading a module before loading hapi
@hueniverse hueniverse merged commit d959b90 into hapijs:master May 18, 2014
1 check passed
@lock lock bot locked as resolved and limited conversation to collaborators Jan 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants