Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference to request in domain. Closes #1634 #1635

Merged
merged 2 commits into from May 13, 2014
Merged

Remove reference to request in domain. Closes #1634 #1635

merged 2 commits into from May 13, 2014

Conversation

@hueniverse
Copy link
Contributor

@hueniverse hueniverse commented May 13, 2014

No description provided.

@hueniverse hueniverse added the bug label May 13, 2014
@hueniverse hueniverse added this to the 4.1.2 milestone May 13, 2014
self.request.log(['hapi', 'internal', 'implementation', 'error'], err);
}
else {
console.error('Debug: late request implementation error:\n ' + err.stack);
Copy link
Contributor

@kpdecker kpdecker May 13, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this make it to a centralized log rather than console log? We for example don't have those going anywhere and no monitoring to speak of on console.

Loading

kpdecker added a commit that referenced this issue May 13, 2014
Remove reference to request in domain. Closes #1634
@kpdecker kpdecker merged commit 8917440 into master May 13, 2014
1 check passed
Loading
@hueniverse hueniverse deleted the issue/1634 branch May 13, 2014
@lock lock bot locked as resolved and limited conversation to collaborators Jan 11, 2020
@lock lock bot unassigned kpdecker Jan 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants