Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log function should only emit once if _server object #1733

Merged
merged 1 commit into from Jul 14, 2014
Merged

log function should only emit once if _server object #1733

merged 1 commit into from Jul 14, 2014

Conversation

@lloydbenson
Copy link
Contributor

@lloydbenson lloydbenson commented Jun 19, 2014

The good plugin seemed to be throwing 2 log entries when I tried to migrate the tests to hapi 6.0 when using server.log with packs. This may potentially fix that issue. Please let me know if instead the issue is with how pack is being used instead, and I should indeed expect 2 emits and handle that appropriately.

@lloydbenson
Copy link
Contributor Author

@lloydbenson lloydbenson commented Jun 19, 2014

If this actually does solve an issue, it may make some sense to make a test to ensure only 1 gets emitted. I took a quick stab at it but did not have much luck.

@hueniverse hueniverse added the bug label Jul 14, 2014
@hueniverse hueniverse added this to the 6.1.0 milestone Jul 14, 2014
@hueniverse hueniverse self-assigned this Jul 14, 2014
hueniverse pushed a commit that referenced this issue Jul 14, 2014
log function should only emit once if _server object
@hueniverse hueniverse merged commit f4e896f into hapijs:master Jul 14, 2014
1 check passed
hueniverse pushed a commit that referenced this issue Jul 14, 2014
@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants