fixes #1755 - stripTrailingSlash doesn't work when query variables are used#1763
Closed
kungfoochris wants to merge 2 commits intohapijs:masterfrom
Closed
fixes #1755 - stripTrailingSlash doesn't work when query variables are used#1763kungfoochris wants to merge 2 commits intohapijs:masterfrom
kungfoochris wants to merge 2 commits intohapijs:masterfrom
Conversation
Fixed a bug where the trailing slash is not ignored when a query string is in use and the option stripTrailingSlash is enabled.
kungfoochris
changed the title
Contributor
|
Awesome. Can you add a test which reproduces the bug and make sure it doesn't pass before the fix, and does pass afterwards? |
Added test for the condition where stripTrailingSlash failed if a query string was present. Test fails before the fix. Passes after the fix.
Author
|
Test created. I reversed my change and it failed. Reapplied the fix and test passes. Let me know if you need me to do anything else before you can pull this in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a bug where the trailing slash is not ignored when a query string is in use and the option stripTrailingSlash is enabled.