Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #1755 - stripTrailingSlash doesn't work when query variables are used #1763

Closed
wants to merge 2 commits into from

Conversation

@kungfoochris
Copy link

@kungfoochris kungfoochris commented Jul 8, 2014

Fixed a bug where the trailing slash is not ignored when a query string is in use and the option stripTrailingSlash is enabled.

Fixed a bug where the trailing slash is not ignored when a query string is in use and the option stripTrailingSlash is enabled.
@kungfoochris kungfoochris changed the title fixes #1755 fixes #1755 - stripTrailingSlash doesn't work when query variables are used Jul 8, 2014
@danielb2
Copy link
Contributor

@danielb2 danielb2 commented Jul 8, 2014

Awesome. Can you add a test which reproduces the bug and make sure it doesn't pass before the fix, and does pass afterwards?

Added test for the condition where stripTrailingSlash failed if a query string was present. Test fails before the fix. Passes after the fix.
@kungfoochris
Copy link
Author

@kungfoochris kungfoochris commented Jul 9, 2014

Test created. I reversed my change and it failed. Reapplied the fix and test passes. Let me know if you need me to do anything else before you can pull this in.

@hueniverse hueniverse added the bug label Jul 14, 2014
@hueniverse hueniverse added this to the 6.1.0 milestone Jul 14, 2014
@hueniverse hueniverse self-assigned this Jul 14, 2014
@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants