Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style fixes #1774

Merged
merged 8 commits into from Jul 14, 2014
Merged

Style fixes #1774

merged 8 commits into from Jul 14, 2014

Conversation

@danielb2
Copy link
Contributor

@danielb2 danielb2 commented Jul 11, 2014

  • Specifically adding return to callbacks
  • fix trailing ; in callback doc
  • remove some unused variables and declarations
  • Misc style fixes
@@ -27,9 +27,9 @@ describe('State', function () {

it('skips parsing cookies', function (done) {

var server = new Hapi.Server({ state: { cookies: { parse: false } } });
Copy link
Contributor

@hueniverse hueniverse Jul 14, 2014

This was right. Always a space before/after non empty {}

@danielb2
Copy link
Contributor Author

@danielb2 danielb2 commented Jul 14, 2014

Updated. It was a case of a bad setting in my .jscsrc :/

@danielb2
Copy link
Contributor Author

@danielb2 danielb2 commented Jul 14, 2014

hold please.

@danielb2
Copy link
Contributor Author

@danielb2 danielb2 commented Jul 14, 2014

Looks like test 831 fails in master also. lab -i 831.

When run as: lab -i 830 -i 831 the failure is intermittent

hueniverse pushed a commit that referenced this issue Jul 14, 2014
@hueniverse hueniverse merged commit b4a3e13 into hapijs:master Jul 14, 2014
1 check failed
@hueniverse hueniverse added this to the 6.1.0 milestone Jul 14, 2014
@hueniverse hueniverse self-assigned this Jul 14, 2014
@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants