Allow agent to be set on proxy options and passed into Nipple.

[ndvivedi]

Changes to support putting an agent on the options argument passed into the proxy handler.

There was an issue created for this previously, that was closed due to inactivity.

#1596

[hueniverse]

Your test isn't actually testing anything...

[ndvivedi]

The test is just asserting that when an agent is set on the options argument to proxy the subsequent call to Nipple.request contains the same object on the agent property of its options argument.

If I remove the change at lines 29-32 in lib/proxy.js the test fails like I would expect.

[hueniverse]

Might as well call done() from inside your mocked nipple.request overload. Add { parallel: false } to the test options to indicate you are messing with internals.

[ndvivedi]

The changes to the test are finished.

[hueniverse]

Update the doc and it's good.

[Marsup]

Shouldn't he also reword Nipple to Wreck ?

[hueniverse]

Yeah, but I clean up everything anyway... :-) I just don't want to write more docs...

[ndvivedi]

Doc is updated.

One extra thing, the test just before the one i added has the same pattern (modifying Nipple.request to do an assertion). I made the same changes as i did to my test, adding the parallel : false option and moving the done() call, but have not submitted it. Do you want that?

[lock]

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.