Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle empty CORS expose-headers header response #1932

Merged
merged 1 commit into from Sep 11, 2014

Conversation

@kanongil
Copy link
Contributor

@kanongil kanongil commented Sep 11, 2014

The access-control-expose-headers should only be included in the response for non-empty lists according to http://www.w3.org/TR/cors/#resource-requests.

This patch fixes the response on servers configured with { cors: { exposedHeaders: [] } }.

@hueniverse hueniverse added the bug label Sep 11, 2014
@hueniverse hueniverse added this to the 6.8.2 milestone Sep 11, 2014
@hueniverse hueniverse self-assigned this Sep 11, 2014
hueniverse pushed a commit that referenced this issue Sep 11, 2014
handle empty CORS expose-headers header response
@hueniverse hueniverse merged commit b648fbb into hapijs:master Sep 11, 2014
1 check passed
@lock
Copy link

@lock lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants