Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non-spec compliant Last-Modified header in response #1934

Merged
merged 1 commit into from Sep 11, 2014

Conversation

@kanongil
Copy link
Contributor

@kanongil kanongil commented Sep 11, 2014

I found that the date in the Last-Modified header of .file() responses are invalid according to http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.29 & http://www.w3.org/Protocols/rfc2616/rfc2616-sec3.html#sec3.3.1.

This patch should fix this issue, generating valid dates, along with an extra test in case of future regressions.

@hueniverse
Copy link
Contributor

@hueniverse hueniverse commented Sep 11, 2014

@hueniverse hueniverse added the bug label Sep 11, 2014
@hueniverse hueniverse self-assigned this Sep 11, 2014
@hueniverse hueniverse added this to the 6.8.2 milestone Sep 11, 2014
hueniverse pushed a commit that referenced this issue Sep 11, 2014
Fix non-spec compliant Last-Modified header in response
@hueniverse hueniverse merged commit c3990e6 into hapijs:master Sep 11, 2014
@lock
Copy link

@lock lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants