Fix non-spec compliant Last-Modified header in response#1934
Merged
Conversation
Contributor
|
The up to date reference is: http://tools.ietf.org/html/rfc7231#section-7.1.1.1 |
hueniverse
pushed a commit
that referenced
this pull request
Sep 11, 2014
Fix non-spec compliant Last-Modified header in response
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that the date in the
Last-Modifiedheader of.file()responses are invalid according to http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.29 & http://www.w3.org/Protocols/rfc2616/rfc2616-sec3.html#sec3.3.1.This patch should fix this issue, generating valid dates, along with an extra test in case of future regressions.