Skip to content

Use environment variables in CLI configuration json file#1955

Merged
hueniverse merged 2 commits intohapijs:masterfrom
jagoda:feat-composer-interpolation
Oct 8, 2014
Merged

Use environment variables in CLI configuration json file#1955
hueniverse merged 2 commits intohapijs:masterfrom
jagoda:feat-composer-interpolation

Conversation

@jagoda
Copy link
Copy Markdown
Contributor

@jagoda jagoda commented Sep 17, 2014

When using cloud environments like Heroku, it is often convenient to specify configuration options via environment variables. This change causes the command line to replace all string values starting with '$env.' in the manifest document with the corresponding environment variable value. This makes it possible to do things like configure plugins that are loaded as part of the pack via environment variables.

@hueniverse hueniverse added the feature New functionality or improvement label Sep 17, 2014
@jagoda
Copy link
Copy Markdown
Contributor Author

jagoda commented Sep 24, 2014

Any thoughts on this? Any chance it will get merged at some point?

@hueniverse
Copy link
Copy Markdown
Contributor

It's in the queue. I'm behind.

@jagoda
Copy link
Copy Markdown
Contributor Author

jagoda commented Sep 25, 2014

Cool, no problem. Thanks for the update!

@hueniverse hueniverse added this to the 6.11.2 milestone Oct 8, 2014
@hueniverse hueniverse self-assigned this Oct 8, 2014
hueniverse pushed a commit that referenced this pull request Oct 8, 2014
Use environment variables in CLI configuration json file
@hueniverse hueniverse merged commit bf9ccb2 into hapijs:master Oct 8, 2014
hueniverse pushed a commit that referenced this pull request Oct 8, 2014
@hueniverse hueniverse modified the milestones: 6.11.2, 7.0.0 Oct 8, 2014
@lock
Copy link
Copy Markdown

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

feature New functionality or improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants