Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use environment variables in CLI configuration json file #1955

Merged
merged 2 commits into from Oct 8, 2014

Conversation

@jagoda
Copy link
Contributor

@jagoda jagoda commented Sep 17, 2014

When using cloud environments like Heroku, it is often convenient to specify configuration options via environment variables. This change causes the command line to replace all string values starting with '$env.' in the manifest document with the corresponding environment variable value. This makes it possible to do things like configure plugins that are loaded as part of the pack via environment variables.

@jagoda
Copy link
Contributor Author

@jagoda jagoda commented Sep 24, 2014

Any thoughts on this? Any chance it will get merged at some point?

@hueniverse
Copy link
Contributor

@hueniverse hueniverse commented Sep 25, 2014

It's in the queue. I'm behind.

@jagoda
Copy link
Contributor Author

@jagoda jagoda commented Sep 25, 2014

Cool, no problem. Thanks for the update!

@hueniverse hueniverse added this to the 6.11.2 milestone Oct 8, 2014
@hueniverse hueniverse self-assigned this Oct 8, 2014
hueniverse pushed a commit that referenced this issue Oct 8, 2014
Use environment variables in CLI configuration json file
@hueniverse hueniverse merged commit bf9ccb2 into hapijs:master Oct 8, 2014
1 check passed
hueniverse pushed a commit that referenced this issue Oct 8, 2014
@hueniverse hueniverse removed this from the 6.11.2 milestone Oct 8, 2014
@hueniverse hueniverse added this to the 7.0.0 milestone Oct 8, 2014
@hueniverse hueniverse added this to the 7.0.0 milestone Oct 8, 2014
@hueniverse hueniverse removed this from the 6.11.2 milestone Oct 8, 2014
@lock
Copy link

@lock lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants