Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vision / Mimos #1968

Merged
merged 8 commits into from Sep 22, 2014
Merged

Vision / Mimos #1968

merged 8 commits into from Sep 22, 2014

Conversation

@hueniverse
Copy link
Contributor

@hueniverse hueniverse commented Sep 22, 2014

Closes #1967
Closes #1969

@hueniverse hueniverse added this to the 6.9.0 milestone Sep 22, 2014
@hueniverse hueniverse changed the title Vision Vision / Mimos Sep 22, 2014
var override = (!options.basePath && env.path ? { basePath: env.path } : null);
env.views = new Views.Manager(options, override);

if (!options.basePath && env.path) {
Copy link
Member

@geek geek Sep 22, 2014

Does this need to be defensive against a null/undefined options?

Copy link
Contributor Author

@hueniverse hueniverse Sep 22, 2014

That's an old issue. There wasn't one before. But I'll add it.

@@ -25,3 +25,16 @@ exports.uniqueFilename = function (path) {
var name = [Date.now(), process.pid, Crypto.randomBytes(8).toString('hex')].join('-');
return Path.join(path, name);
};


exports.shallow = function (source) {
Copy link
Member

@geek geek Sep 22, 2014

Copy link
Contributor Author

@hueniverse hueniverse Sep 22, 2014

Not the same. Clone with shallow is expensive and requires listing all shallow keys.

geek added a commit that referenced this issue Sep 22, 2014
@geek geek merged commit dfac28f into master Sep 22, 2014
1 check passed
@geek geek deleted the vision branch Sep 22, 2014
@lock
Copy link

@lock lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants