Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show route method in error message #2002

Merged
merged 1 commit into from Oct 5, 2014
Merged

Conversation

@chulkilee
Copy link
Contributor

@chulkilee chulkilee commented Oct 3, 2014

Showing only path is not enough to identify the exact route configuration when there are multiple methods for the same path.

@hueniverse
Copy link
Contributor

@hueniverse hueniverse commented Oct 3, 2014

If you are going to make this change, be consistent and make it across all the other assertions...

@hueniverse hueniverse self-assigned this Oct 3, 2014
@chulkilee chulkilee force-pushed the route-error-mesg branch from e109ebf to 8d5c1d6 Oct 5, 2014
@chulkilee
Copy link
Contributor Author

@chulkilee chulkilee commented Oct 5, 2014

That makes sense. I amended the commit to add options.method when adding options.path.

@hueniverse hueniverse added this to the 6.11.1 milestone Oct 5, 2014
hueniverse pushed a commit that referenced this issue Oct 5, 2014
show route method in error message
@hueniverse hueniverse merged commit 3d0b093 into hapijs:master Oct 5, 2014
1 check passed
@lock
Copy link

@lock lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants