Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pack refactor #2057

Merged
merged 14 commits into from Oct 28, 2014
Merged

Pack refactor #2057

merged 14 commits into from Oct 28, 2014

Conversation

@hueniverse
Copy link
Contributor

@hueniverse hueniverse commented Oct 28, 2014

Closes #2054
Closes #2055
Closes #2056


return server;
this.connections.push(connection);
++this.length;
Copy link
Member

@geek geek Oct 28, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems more readable as this.length++; but maybe thats just me

Loading

geek added a commit that referenced this issue Oct 28, 2014
@geek geek merged commit db2c84e into master Oct 28, 2014
1 check passed
Loading
@geek geek deleted the 8 branch Oct 28, 2014
@lock
Copy link

@lock lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

Loading

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants