Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2308 by logging boom error object instead of just message #2309

Merged
merged 1 commit into from Feb 8, 2015

Conversation

@dschenkelman
Copy link
Contributor

@dschenkelman dschenkelman commented Dec 19, 2014

No description provided.

@@ -76,7 +76,7 @@ internals.handler = function (request, callback) {
// Check for Error result

if (response.isBoom) {
request._log(['handler', 'error'], { msec: timer.elapsed(), error: response.message });
request._log(['handler', 'error'], { msec: timer.elapsed(), error: response });
Copy link
Contributor

@hueniverse hueniverse Jan 5, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be a breaking change. Instead, just add data field with the full response.

Loading

@dschenkelman
Copy link
Contributor Author

@dschenkelman dschenkelman commented Jan 30, 2015

Is there anything else that needs to be done from my side? I understand you might be busy, just asking in case something is expected.

Loading

@hueniverse hueniverse added this to the 8.2.0 milestone Feb 8, 2015
hueniverse pushed a commit that referenced this issue Feb 8, 2015
Fixes #2308 by logging boom error object instead of just message
@hueniverse hueniverse merged commit 2e1e695 into hapijs:master Feb 8, 2015
1 check passed
Loading
hueniverse pushed a commit that referenced this issue Feb 8, 2015
@dschenkelman dschenkelman deleted the issues/2308 branch Feb 12, 2015
@lock
Copy link

@lock lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

Loading

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants