Don't respond to connections until listening is started #2362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What exactly is the problem it is trying to solve? Why would there be connections before the listener is active? |
|
The test I fixed was supposed to check that a stopped server will remove attached connection listeners. The code did not do this, so I fixed it by delaying the attaching until the server is actually listening (after someone has called start). If you don't care about the extra listener, the test should probably be revised to check that the listener count matches after each |
hueniverse
pushed a commit
that referenced
this pull request
Feb 9, 2015
Don't respond to connections until listening is started
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes the removes connection event listeners after it stops test to do what it says.