Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #2427 #2429

Merged
merged 1 commit into from Mar 5, 2015
Merged

Fix for #2427 #2429

merged 1 commit into from Mar 5, 2015

Conversation

@kanongil
Copy link
Contributor

@kanongil kanongil commented Feb 24, 2015

This includes a new test that fails on all version of node.

I'm not entirely sure that the fix I have implemented is the best way to handle this issue but it seems to do the trick without messing up any other tests.

@kanongil kanongil added the bug label Feb 24, 2015
@hueniverse hueniverse self-assigned this Mar 5, 2015
@hueniverse hueniverse added this to the 8.3.0 milestone Mar 5, 2015
hueniverse pushed a commit that referenced this issue Mar 5, 2015
@hueniverse hueniverse merged commit d1ec2d5 into hapijs:master Mar 5, 2015
1 check passed
@hueniverse
Copy link
Contributor

@hueniverse hueniverse commented Mar 5, 2015

Removing the fix does not break the test.

@kanongil
Copy link
Contributor Author

@kanongil kanongil commented Mar 6, 2015

@hueniverse Are you sure? I just checked on master and it still fails for me.

FYI, I'm on node v0.10.36 on Yosemite.

hueniverse pushed a commit that referenced this issue Mar 6, 2015
hueniverse pushed a commit that referenced this issue Mar 6, 2015
@kanongil
Copy link
Contributor Author

@kanongil kanongil commented Mar 10, 2015

@hueniverse I can see you have made your own fix, which is probably wise. However it has issues on node 0.10 as seen in this travis log: https://travis-ci.org/hapijs/hapi/jobs/53393303

It seems your fix requires streams3 for full support.

@hueniverse
Copy link
Contributor

@hueniverse hueniverse commented Mar 10, 2015

@kanongil yeah, I need to find a way around that to first drain the stream. Have been busy with other stuff.

@lock
Copy link

@lock lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants