Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test for server.ext with complex deps. #2642

Merged
merged 6 commits into from Jul 29, 2015

Conversation

@devinivy
Copy link
Member

@devinivy devinivy commented Jul 12, 2015

Using server.ext option before as an array misbehaves, essentially ignoring the dependencies.

Root cause in topo has a pending PR: hapijs/topo#7. I've verified that patching topo allows all tests to pass.

@hueniverse
Copy link
Contributor

@hueniverse hueniverse commented Jul 29, 2015

Can you rewrite this test not to change existing tests? Just add a new it() block that doesn't touch all the other tests. At some point I want to break up all the common plugins used in there.

@hueniverse hueniverse self-assigned this Jul 29, 2015
@hueniverse hueniverse added the bug label Jul 29, 2015
@devinivy
Copy link
Member Author

@devinivy devinivy commented Jul 29, 2015

Should be resolved now!


server.route({ method: 'GET', path: '/', handler: handler });

server.register([internals.plugins.deps1, internals.plugins.deps2, internals.plugins.deps3], function (err) {
Copy link
Contributor

@hueniverse hueniverse Jul 29, 2015

Don't use the internals plugin here. Create three new ones inside the test.

Copy link
Member Author

@devinivy devinivy Jul 29, 2015

Makes sense, given what you said. I made those updates for you.

@hueniverse hueniverse added this to the 8.8.1 milestone Jul 29, 2015
hueniverse pushed a commit that referenced this issue Jul 29, 2015
Failing test for `server.ext` with complex deps.
@hueniverse hueniverse merged commit f11237a into hapijs:master Jul 29, 2015
1 check failed
@lock
Copy link

@lock lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants